[stable-9] Unit tests: make set_module_args() a context manager, and remove copies of it in some tests (#9840)

Unit tests: make set_module_args() a context manager, and remove copies of it in some tests (#9838)

Make set_module_args() a context manager, and remove copies of set_module_args().

Prepares for Data Tagging.

(cherry picked from commit a1781d09dd)
This commit is contained in:
Felix Fontein 2025-03-07 07:31:42 +01:00 committed by GitHub
parent 9a6bd80613
commit 013fb9c006
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
80 changed files with 3745 additions and 3977 deletions

View file

@ -114,25 +114,24 @@ class TestKeycloakUser(ModuleTestCase):
return_update_user = None
changed = True
set_module_args(module_args)
# Run the module
with mock_good_connection():
with patch_keycloak_api(get_user_by_username=return_value_get_user_by_username,
create_user=return_create_user,
update_user_groups_membership=return_value_update_user_groups_membership,
get_user_groups=return_get_user_groups,
update_user=return_update_user,
delete_user=return_delete_user) \
as (mock_get_user_by_username,
mock_create_user,
mock_update_user_groups_membership,
mock_get_user_groups,
mock_delete_user,
mock_update_user):
with self.assertRaises(AnsibleExitJson) as exec_info:
self.module.main()
with set_module_args(module_args):
with mock_good_connection():
with patch_keycloak_api(get_user_by_username=return_value_get_user_by_username,
create_user=return_create_user,
update_user_groups_membership=return_value_update_user_groups_membership,
get_user_groups=return_get_user_groups,
update_user=return_update_user,
delete_user=return_delete_user) \
as (mock_get_user_by_username,
mock_create_user,
mock_update_user_groups_membership,
mock_get_user_groups,
mock_delete_user,
mock_update_user):
with self.assertRaises(AnsibleExitJson) as exec_info:
self.module.main()
self.assertEqual(mock_get_user_by_username.call_count, 1)
self.assertEqual(mock_create_user.call_count, 1)
@ -176,25 +175,24 @@ class TestKeycloakUser(ModuleTestCase):
return_update_user = None
changed = False
set_module_args(module_args)
# Run the module
with mock_good_connection():
with patch_keycloak_api(get_user_by_username=return_value_get_user_by_username,
create_user=return_create_user,
update_user_groups_membership=return_value_update_user_groups_membership,
get_user_groups=return_get_user_groups,
update_user=return_update_user,
delete_user=return_delete_user) \
as (mock_get_user_by_username,
mock_create_user,
mock_update_user_groups_membership,
mock_get_user_groups,
mock_delete_user,
mock_update_user):
with self.assertRaises(AnsibleExitJson) as exec_info:
self.module.main()
with set_module_args(module_args):
with mock_good_connection():
with patch_keycloak_api(get_user_by_username=return_value_get_user_by_username,
create_user=return_create_user,
update_user_groups_membership=return_value_update_user_groups_membership,
get_user_groups=return_get_user_groups,
update_user=return_update_user,
delete_user=return_delete_user) \
as (mock_get_user_by_username,
mock_create_user,
mock_update_user_groups_membership,
mock_get_user_groups,
mock_delete_user,
mock_update_user):
with self.assertRaises(AnsibleExitJson) as exec_info:
self.module.main()
self.assertEqual(mock_get_user_by_username.call_count, 1)
self.assertEqual(mock_create_user.call_count, 0)
@ -257,25 +255,24 @@ class TestKeycloakUser(ModuleTestCase):
]
changed = True
set_module_args(module_args)
# Run the module
with mock_good_connection():
with patch_keycloak_api(get_user_by_username=return_value_get_user_by_username,
create_user=return_create_user,
update_user_groups_membership=return_value_update_user_groups_membership,
get_user_groups=return_get_user_groups,
update_user=return_update_user,
delete_user=return_delete_user) \
as (mock_get_user_by_username,
mock_create_user,
mock_update_user_groups_membership,
mock_get_user_groups,
mock_delete_user,
mock_update_user):
with self.assertRaises(AnsibleExitJson) as exec_info:
self.module.main()
with set_module_args(module_args):
with mock_good_connection():
with patch_keycloak_api(get_user_by_username=return_value_get_user_by_username,
create_user=return_create_user,
update_user_groups_membership=return_value_update_user_groups_membership,
get_user_groups=return_get_user_groups,
update_user=return_update_user,
delete_user=return_delete_user) \
as (mock_get_user_by_username,
mock_create_user,
mock_update_user_groups_membership,
mock_get_user_groups,
mock_delete_user,
mock_update_user):
with self.assertRaises(AnsibleExitJson) as exec_info:
self.module.main()
self.assertEqual(mock_get_user_by_username.call_count, 1)
self.assertEqual(mock_create_user.call_count, 0)
@ -319,25 +316,24 @@ class TestKeycloakUser(ModuleTestCase):
return_update_user = None
changed = True
set_module_args(module_args)
# Run the module
with mock_good_connection():
with patch_keycloak_api(get_user_by_username=return_value_get_user_by_username,
create_user=return_create_user,
update_user_groups_membership=return_value_update_user_groups_membership,
get_user_groups=return_get_user_groups,
update_user=return_update_user,
delete_user=return_delete_user) \
as (mock_get_user_by_username,
mock_create_user,
mock_update_user_groups_membership,
mock_get_user_groups,
mock_delete_user,
mock_update_user):
with self.assertRaises(AnsibleExitJson) as exec_info:
self.module.main()
with set_module_args(module_args):
with mock_good_connection():
with patch_keycloak_api(get_user_by_username=return_value_get_user_by_username,
create_user=return_create_user,
update_user_groups_membership=return_value_update_user_groups_membership,
get_user_groups=return_get_user_groups,
update_user=return_update_user,
delete_user=return_delete_user) \
as (mock_get_user_by_username,
mock_create_user,
mock_update_user_groups_membership,
mock_get_user_groups,
mock_delete_user,
mock_update_user):
with self.assertRaises(AnsibleExitJson) as exec_info:
self.module.main()
self.assertEqual(mock_get_user_by_username.call_count, 1)
self.assertEqual(mock_create_user.call_count, 0)