From 0123222ba86b153735c7621c7e898482721ade95 Mon Sep 17 00:00:00 2001 From: "patchback[bot]" <45432694+patchback[bot]@users.noreply.github.com> Date: Sun, 10 Aug 2025 13:51:58 +0200 Subject: [PATCH] [PR #10620/a68ba504 backport][stable-11] homectl, maven_artifact: removed redundant comments (#10622) homectl, maven_artifact: removed redundant comments (#10620) * homectl, maven_artifact: removed redundant comments * stacki_hosts: one more redundant comment (cherry picked from commit a68ba50466381b95dfa827772802fffa41634ad2) Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com> --- plugins/modules/homectl.py | 2 -- plugins/modules/maven_artifact.py | 4 ++-- plugins/modules/stacki_host.py | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/plugins/modules/homectl.py b/plugins/modules/homectl.py index f93867d03b..7d41c659ff 100644 --- a/plugins/modules/homectl.py +++ b/plugins/modules/homectl.py @@ -297,8 +297,6 @@ else: class Homectl(object): - '''#TODO DOC STRINGS''' - def __init__(self, module): self.module = module self.state = module.params['state'] diff --git a/plugins/modules/maven_artifact.py b/plugins/modules/maven_artifact.py index af3be70f39..fb7eb830f0 100644 --- a/plugins/modules/maven_artifact.py +++ b/plugins/modules/maven_artifact.py @@ -630,7 +630,7 @@ def main(): password=dict(no_log=True, aliases=['aws_secret_access_key']), headers=dict(type='dict'), force_basic_auth=dict(default=False, type='bool'), - state=dict(default="present", choices=["present", "absent"]), # TODO - Implement a "latest" state + state=dict(default="present", choices=["present", "absent"]), timeout=dict(default=10, type='int'), dest=dict(type="path", required=True), validate_certs=dict(default=True, type='bool'), @@ -647,7 +647,7 @@ def main(): ) if module.params['unredirected_headers'] is None: - # if the user did not supply unredirected params, we use the default, ONLY on ansible core 2.12 and above + # if the user did not supply unredirected params, we use the default module.params['unredirected_headers'] = ['Authorization', 'Cookie'] if not HAS_LXML_ETREE: diff --git a/plugins/modules/stacki_host.py b/plugins/modules/stacki_host.py index 095e0b7256..ac2caf9089 100644 --- a/plugins/modules/stacki_host.py +++ b/plugins/modules/stacki_host.py @@ -269,7 +269,7 @@ def main(): for param in ['appliance', 'rack', 'rank', 'prim_intf', 'prim_intf_ip', 'network', 'prim_intf_mac']: if not module.params[param]: missing_params.append(param) - if len(missing_params) > 0: # @FIXME replace with required_if + if len(missing_params) > 0: module.fail_json(msg="missing required arguments: {0}".format(missing_params)) stacki.stack_add(result)