ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-04-08 19:50:30 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Added Arguments for Facter module (#768)

Browse source 
* Added arguments and Documentation

* fixing sanity checks

* Added documentation

* attempting doc fix

* removed elements from doc

* updated elements

* Update plugins/modules/system/facter.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Update plugins/modules/system/facter.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Create 768-factor.yml

added change log

* Rename 768-factor.yml to 768-facter.yml

* Update changelogs/fragments/768-facter.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Updated Doc, simplified arg add

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
Larry 2020-11-23 11:59:09 -06:00 • committed by GitHub
parent 3d66ed3ae3
commit 00c2ec062d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 35 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/768-facter.yml Normal file
View file

@ -0,0 +1,2 @@
minor_changes:
- facter - added option for ``arguments`` (https://github.com/ansible-collections/community.general/pull/768).

43
plugins/modules/system/facter.py
View file

@ -12,20 +12,37 @@ DOCUMENTATION = '''
module: facter module: facter
short_description: Runs the discovery program I(facter) on the remote system short_description: Runs the discovery program I(facter) on the remote system
description: description:
- Runs the I(facter) discovery program - Runs the C(facter) discovery program
(U(https://github.com/puppetlabs/facter)) on the remote system, returning (U(https://github.com/puppetlabs/facter)) on the remote system, returning
JSON data that can be useful for inventory purposes. JSON data that can be useful for inventory purposes.
options:
arguments:
description:
- Specifies arguments for facter.
type: list
elements: str
requirements: requirements:
- facter - facter
- ruby-json - ruby-json
author: author:
- Ansible Core Team - Ansible Core Team
- Michael DeHaan - Michael DeHaan
''' '''
EXAMPLES = ''' EXAMPLES = '''
# Example command-line invocation # Example command-line invocation
ansible www.example.net -m facter # ansible www.example.net -m facter
- name: Execute facter no arguments
community.general.facter:
- name: Execute facter with arguments
community.general.facter:
arguments:
- -p
- system_uptime
- timezone
- is_virtual
''' '''
import json import json
@ -34,12 +51,18 @@ from ansible.module_utils.basic import AnsibleModule
def main(): def main():
module = AnsibleModule( module = AnsibleModule(
argument_spec=dict() argument_spec=dict(
arguments=dict(required=False, type='list', elements='str')
)
) )
facter_path = module.get_bin_path('facter', opt_dirs=['/opt/puppetlabs/bin']) facter_path = module.get_bin_path(
'facter',
opt_dirs=['/opt/puppetlabs/bin'])
cmd = [facter_path, "--json"] cmd = [facter_path, "--json"]
if module.params['arguments']:
cmd += module.params['arguments']
rc, out, err = module.run_command(cmd, check_rc=True) rc, out, err = module.run_command(cmd, check_rc=True)
module.exit_json(**json.loads(out)) module.exit_json(**json.loads(out))